Received-SPF: pass
 receiver=post.selbstdenker.com; client-ip=209.85.160.176; envelope-from=recurve@cocoanutstech.com
From: Aaron Rosenzweig <aaron@chatnbike.com>
Content-Type: text/plain;
	charset=utf-8
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\))
Subject: When add-exports ALL-UNNAMED is not enough (Java 17)
Message-Id: <F6F8838B-FAD0-4C4A-85BA-F6092AC716FE@chatnbike.com>
Date: Wed, 7 Dec 2022 17:42:57 -0500
To: WebObjects & WOnder Development <webobjects-dev@wocommunity.org>

Hi WOrriors,=20

I=E2=80=99m upgrading to Java 17 from Java 1.8 and have run into snags =
in my local Eclipse workspace. Perhaps you=E2=80=99ve struggled with =
this too?=20

In general, this VM argument is helpful but not enough: --add-exports =
java.base/sun.security.action=3DALL-UNNAMED

The issue has to do with changes from Java 1.8 and java modules.=20

I can use 1.8 compatibility mode with my workspace (from Java 17 VM) and =
there are no errors and no problems.=20

When I change to Java 17 compatibility mode, it falls apart.=20

My java apps are ok, but many of the WOnder frameworks don=E2=80=99t =
build anymore.=20

For example ERAttachment. I have this error: The package org.xml.sax is =
accessible from more than one module: <unnamed>, java.xml

To me that means that it is available in a system module =E2=80=9Cjava.xml=
=E2=80=9D and also in some old jar file=E2=80=A6 two places.=20

I clicked on ERAttachment (in WO Explorer pane) and then right click to =
do "build path" and then "configure build path." I then went to the last =
tab "Module Dependencies" clicked "java.xml" and then clicked "remove." =
It gave me warnings that other things use it but I did it anyway. Now =
the errors are gone for org.xml.sax.Attributes and similar imports. Yay!=20=


I=E2=80=99m not done yet but I did similar things as follows:
	=E2=80=A2 ERAttachment - remove java.xml
	=E2=80=A2 ERRest - remove java.xml
	=E2=80=A2 ERChangeNotificationJMS - remove java.naming
	=E2=80=A2 ExcelGenerator - remove java.xml
	=E2=80=A2 ERPDFGeneration - remove java.xml
	=E2=80=A2 ERSelenium - remove java.xml
	=E2=80=A2 ERXiss - remove java.xml
	=E2=80=A2 DRGrouping - remove java.xml
	=E2=80=A2 ERJaxWS - remove java.xml
	=E2=80=A2 ERProfiling - lost cause? jdk.internal.loader is =
inaccessible so I closed the project in my workspace (and am not =
currently using it).

I=E2=80=99m still coming to grips with all this but I have following =
unresolved and possibly incorrectly stated questions:

1) Do most of us run with 1.8 compatibility in newer JVMs and leave it =
at that?=20

2) Do some of us run with newer VM compatibility modes (to access new =
features of Java) but then use =E2=80=9CALL-UNNAMED=E2=80=9D hacks along =
with removing system module hacks like I was talking about above?=20

3) Do some of us use pre-built jars of Wonder and not build from source =
in our Eclipse projects to get around some of these issues? But if so, =
that means it=E2=80=99s not as nice to just dive into the source code =
and quickly trace / change things as we are working...

4) Should we consider putting WOnder frameworks into module friendly =
configurations? Or is that not possible because we need to support Java =
1.8 too?=20

5) What is the best way to use Java 17 VM along with any new java syntax =
/ functionality while still using WOnder frameworks?=20

Thanks to all for reading this far :-)
=E2=80=94 Aaron=