X-CGP-ClamAV-Result: CLEAN X-VirusScanner: Niversoft's CGPClamav Helper v1.25a (ClamAV 0.103.8/26879) X-Junk-Score: 0 [] X-KAS-Score: 0 [] Return-Path: Received: from out5-smtp.messagingengine.com ([66.111.4.29] verified) by post.selbstdenker.com (CommuniGate Pro SMTP 6.3.18) with ESMTPS id 30643407 for webobjects-dev@wocommunity.org; Wed, 19 Apr 2023 08:23:12 +0200 Received-SPF: pass receiver=post.selbstdenker.com; client-ip=66.111.4.29; envelope-from=paulh@logicsquad.net Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id BC7DF5C00AE for ; Wed, 19 Apr 2023 02:22:51 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 19 Apr 2023 02:22:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=logicsquad.net; h=cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; t=1681885371; x=1681971771; bh=wL 3ERPAm5/8NBAg/AE6Ue5Ija7vJ/LBWkJOPxVhf12g=; b=Fr/tpgmZCjmAXfXec2 XKZRHQlCQ5Mg0jJK9WLrAN0EY3OAq93kEToQXkQSFOOQNpacPthw3TIJcDNKUd8R jULCi7no6Rawtj2GkoQMrTWxl0gPWapIxfkPMlSzIyBRAPsgdpDq6AbnQnVmeuGZ bfehKvGi04YCI1/u4ndmic8kjBBThuDkePR90X7EckqgPziF/WB6qyHgbbXovhh0 Gx3iB3Ju+8OX5j2sHUsCMjbZW4r1vAkcA4Vl43xvTJP8NmL4nOs0x829pVa6a7nr 13cOe7qrtbCJrD7qeNHiyx42eepKLq/q9T6uamzukolJfm4tnfNr7LsNUjXnp5zG 3vhA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1681885371; x=1681971771; bh=wL3ERPAm5/8NB Ag/AE6Ue5Ija7vJ/LBWkJOPxVhf12g=; b=e1aEZtdCuekO0tTIzs1b1adE3mMav l45z9HSYwMTQ132KIV2hP3dRRYY+/KGkWeX86/ya2DtBOnFTw0v7mYqAzIn9SXui tbQa0XOHJ/K+S0mEbLn4Y0iidKxYnBbD0gm9Nq81sBt+mpbOrzJf2o6k6LWHpagR cGC+D6dT0yxBovQh5GvYi4ZB9hL4FKrrV/ePimaYS18wI0UsxFq3aGbkwuOteCD7 5fHKHGdNoGnyzWd0bv7sMA59gqRnwZQC9JmjbkPpMg++BcOpFHMcb6CQZqF0sjDb 5aABv1iOVOXWnjfTJcyLjH2D4ZLdqHAfNUvQo+1+/dXvZaphN9XuX4N1Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdelledguddutdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhtggguffffhfvjgfkofesrgdtmherhhdtjeenucfhrhhomheprfgruhhl ucfjohgrughlvgihuceophgruhhlhheslhhoghhitghsqhhurggurdhnvghtqeenucggtf frrghtthgvrhhnpeetgffgudegfeehfeelueektdekhfffheffhffhvdevgeetuedtueeu ieffveegieenucffohhmrghinhepghhithhhuhgsrdgtohhmpdhlohhgihgtshhquhgrug drnhgvthdplhhinhhkvgguihhnrdgtohhmnecuvehluhhsthgvrhfuihiivgeptdenucfr rghrrghmpehmrghilhhfrhhomhepphgruhhlhheslhhoghhitghsqhhurggurdhnvght X-ME-Proxy: Feedback-ID: i671c40f3:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Wed, 19 Apr 2023 02:22:50 -0400 (EDT) From: Paul Hoadley Content-Type: multipart/alternative; boundary="Apple-Mail=_06C43450-0D15-4E21-8580-8F6F7BA1A7F1" Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.2\)) Subject: Re: [WO-DEV] Two minor pull requests Date: Wed, 19 Apr 2023 15:52:46 +0930 References: To: WebObjects & WOnder Development In-Reply-To: Message-Id: <6054CCA2-2B8B-4EC8-9B28-25085CD5CE7D@logicsquad.net> X-Mailer: Apple Mail (2.3696.120.41.1.2) --Apple-Mail=_06C43450-0D15-4E21-8580-8F6F7BA1A7F1 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Hi Aaron, On 18 Apr 2023, at 23:19, Aaron Rosenzweig wrote: > We=E2=80=99d like to do more improvements to JavaMonitor. About four = years ago, Marco=E2=80=99s changes to JavaMonitor were pulled in namely = "Add ability to select instance names using a regex expression=E2=80=9D = =E2=80=94 He=E2=80=99s eager to do more. This is fantastic! > I=E2=80=99m wondering if a committer could look at two minor pull = requests Marco has made recently and approve them?=20 >=20 > 1) Adding WOOgnl framework to JavaMonitor > https://github.com/wocommunity/wonder/pull/1012 = > This one is real simple, changing the project to include the existing = WOnder WOOgnl framework. It will lay the groundwork to make it more = enticing for Marco to continue to develop JavaMonitor. He won=E2=80=99t = be doing any wild logic within bindings but be doing basic things, it = would make it simpler for him to have WOOgnl available.=20 I've suggested Marco amend the PR to include the corresponding Maven = dependency in the POM. > 2) Correcting HTML within JavaMonitor > https://github.com/wocommunity/wonder/pull/1013 = > This one is simple too, restructuring Main to pass basic HTML = validation. For example, meta tags should not be outside of the HTML = tags. This pull requests puts the meta-refresh inside of the HEAD tags.=20= Merged. > If these could be approved and committed in the next two weeks that = would be awesome :-) Let=E2=80=99s keep Marco excited and wanting to = contribute more :-) Later pull requests will likely be more = substantial/interesting.=20 I look forward to them! --=20 Paul Hoadley https://logicsquad.net/ https://www.linkedin.com/company/logic-squad/ --Apple-Mail=_06C43450-0D15-4E21-8580-8F6F7BA1A7F1 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8 Hi = Aaron,

On 18 Apr 2023, at 23:19, = Aaron Rosenzweig <aaron@chatnbike.com> wrote:

We=E2=80= =99d like to do more improvements to JavaMonitor. About four years ago, = Marco=E2=80=99s changes to JavaMonitor were pulled in namely "Add = ability to select instance names using a regex expression=E2=80=9D =E2=80=94= He=E2=80=99s eager to do more.

This is fantastic!

I=E2=80=99m wondering if = a committer could look at two minor pull requests Marco has made = recently and approve them? 

1) Adding WOOgnl framework to = JavaMonitor
https://github.com/wocommunity/wonder/pull/1012
This one is real simple, changing the project to include the = existing WOnder WOOgnl framework. It will lay the groundwork to make it = more enticing for Marco to continue to develop JavaMonitor. He won=E2=80=99= t be doing any wild logic within bindings but be doing basic things, it = would make it simpler for him to have WOOgnl = available. 

I've suggested Marco amend the PR to include the = corresponding Maven dependency in the POM.

2) Correcting HTML within = JavaMonitor
https://github.com/wocommunity/wonder/pull/1013
This one is simple too, restructuring Main to pass basic HTML = validation. For example, meta tags should not be outside of the HTML = tags. This pull requests puts the meta-refresh inside of the HEAD = tags. 

Merged.

If these could be approved and committed in = the next two weeks that would be awesome :-) Let=E2=80=99s keep Marco = excited and wanting to contribute more :-) Later pull requests will = likely be more = substantial/interesting. 

I look forward to them!


-- 
Paul = Hoadley
https://logicsquad.net/
https://www.linkedin.com/company/logic-squad/

= --Apple-Mail=_06C43450-0D15-4E21-8580-8F6F7BA1A7F1--