X-CGP-ClamAV-Result: CLEAN X-VirusScanner: Niversoft's CGPClamav Helper v1.25a (ClamAV 0.103.8/26880) X-Junk-Score: 0 [] X-KAS-Score: 0 [] Return-Path: Received: from mail-qv1-f44.google.com ([209.85.219.44] verified) by selbstdenker.ag (CommuniGate Pro SMTP 6.3.18) with ESMTPS id 30645111 for webobjects-dev@wocommunity.org; Wed, 19 Apr 2023 14:28:01 +0200 Received-SPF: pass receiver=post.selbstdenker.com; client-ip=209.85.219.44; envelope-from=recurve@cocoanutstech.com Received: by mail-qv1-f44.google.com with SMTP id bo1so202296qvb.8 for ; Wed, 19 Apr 2023 05:28:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chatnbike.com; s=chatnbike; t=1681907260; x=1684499260; h=to:references:message-id:cc:date:in-reply-to:from:subject :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=gT69Xub8o95WW+UvhqzxJSrSJJ0Gk+/nX7z87ZPpshI=; b=ZyrbHek7ZyOXqrxmwIMx8G5WRH1KQZgXyE8nF4z0K3ctovloIUiftm2E9lFNKY/mpm EA51zSB8rFQv7SuogmJ0DX9jGm/K1d24WUASMgkDyQtbBJXCntIzqCrJOMObs+3f/Eu8 uO0KtCEWT90xJ0TF8H9ZGsKteMm1FOiYeRi4c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681907260; x=1684499260; h=to:references:message-id:cc:date:in-reply-to:from:subject :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gT69Xub8o95WW+UvhqzxJSrSJJ0Gk+/nX7z87ZPpshI=; b=ce2EIcpfrAYY3R0VcCMSW9G5jNBED6IvFqcnjGW2yV9LtD+1s7RBpL0uJ1n1EompNi TBwCPvUENZ/cP2O4moidVZD5xOct84LYqhIRcRYRAQ/D7GW01TcIq8fCHFvNaOkCWFU6 LfYPcZSWnfUz+ked2NynhuiDWff8CBZBsofn/bm9ylhVfky+PeUEsfGjKsw/qWAx4qqU iMnj/xbftaYGa88lJA3mxqksNsKZV1Gw0Mun9UvjGBAgeToaciVQPUu3Cmx9QeVpXEr2 CYpcI5iGDmLv0dbkqoQ55fMaXmMGudYpRChsg87HTrvnM0w1G2pMuAPJ/SlCKJcfO/88 DKyg== X-Gm-Message-State: AAQBX9cEqOzYs+iUvlXVOesD8cgu2N8BtDj/2DUN56ysHfkevQ1Lwgq9 bdU2LVQop7kN3+zrAuzdSAI1EKgCZXLapVOF41Q= X-Google-Smtp-Source: AKy350YV8qdFN1X88tAT/Hl1EEVSg/mNeC+U7yF+R+qWzhyQ+rFK9JYUzrvty2Ky43KW2N0a+unXbg== X-Received: by 2002:a05:6214:4106:b0:5ac:fb9a:67a1 with SMTP id kc6-20020a056214410600b005acfb9a67a1mr27450472qvb.47.1681907259875; Wed, 19 Apr 2023 05:27:39 -0700 (PDT) Return-Path: Received: from smtpclient.apple (pool-173-79-19-72.washdc.fios.verizon.net. [173.79.19.72]) by smtp.gmail.com with ESMTPSA id oh6-20020a056214438600b005dd8b934597sm4354228qvb.47.2023.04.19.05.27.37 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 19 Apr 2023 05:27:38 -0700 (PDT) Content-Type: multipart/alternative; boundary="Apple-Mail=_28F801A2-E1EA-41D0-AA94-DC29D01D2AFE" Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.2\)) Subject: Re: [WO-DEV] Two minor pull requests From: Aaron Rosenzweig In-Reply-To: Date: Wed, 19 Apr 2023 08:27:37 -0400 Cc: paulh@logicsquad.net Message-Id: <3178B08C-2275-4983-BFE1-3B2E79986B34@chatnbike.com> References: To: WebObjects & WOnder Development X-Mailer: Apple Mail (2.3696.120.41.1.2) --Apple-Mail=_28F801A2-E1EA-41D0-AA94-DC29D01D2AFE Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Thank you Paul! Good eye! Yes we=E2=80=99ll modify the POM file :-) Thanks again, =E2=80=94 Aaron > On Apr 19, 2023, at 2:22 AM, Paul Hoadley = wrote: >=20 > Hi Aaron, >=20 > On 18 Apr 2023, at 23:19, Aaron Rosenzweig > wrote: >=20 >> We=E2=80=99d like to do more improvements to JavaMonitor. About four = years ago, Marco=E2=80=99s changes to JavaMonitor were pulled in namely = "Add ability to select instance names using a regex expression=E2=80=9D = =E2=80=94 He=E2=80=99s eager to do more. >=20 > This is fantastic! >=20 >> I=E2=80=99m wondering if a committer could look at two minor pull = requests Marco has made recently and approve them?=20 >>=20 >> 1) Adding WOOgnl framework to JavaMonitor >> https://github.com/wocommunity/wonder/pull/1012 = >> This one is real simple, changing the project to include the existing = WOnder WOOgnl framework. It will lay the groundwork to make it more = enticing for Marco to continue to develop JavaMonitor. He won=E2=80=99t = be doing any wild logic within bindings but be doing basic things, it = would make it simpler for him to have WOOgnl available.=20 >=20 > I've suggested Marco amend the PR to include the corresponding Maven = dependency in the POM. >=20 >> 2) Correcting HTML within JavaMonitor >> https://github.com/wocommunity/wonder/pull/1013 = >> This one is simple too, restructuring Main to pass basic HTML = validation. For example, meta tags should not be outside of the HTML = tags. This pull requests puts the meta-refresh inside of the HEAD tags.=20= >=20 > Merged. >=20 >> If these could be approved and committed in the next two weeks that = would be awesome :-) Let=E2=80=99s keep Marco excited and wanting to = contribute more :-) Later pull requests will likely be more = substantial/interesting.=20 >=20 > I look forward to them! >=20 >=20 > --=20 > Paul Hoadley > https://logicsquad.net/ > https://www.linkedin.com/company/logic-squad/ >=20 --Apple-Mail=_28F801A2-E1EA-41D0-AA94-DC29D01D2AFE Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8 Thank= you Paul!

Good eye! = Yes we=E2=80=99ll modify the POM file :-)

Thanks again,
=E2=80= =94 Aaron

On Apr 19, 2023, at 2:22 AM, Paul Hoadley <paulh@logicsquad.net> wrote:

Hi Aaron,

On 18 Apr 2023, at 23:19, = Aaron Rosenzweig <aaron@chatnbike.com> wrote:

We=E2=80= =99d like to do more improvements to JavaMonitor. About four years ago, = Marco=E2=80=99s changes to JavaMonitor were pulled in namely "Add = ability to select instance names using a regex expression=E2=80=9D =E2=80=94= He=E2=80=99s eager to do more.

This is = fantastic!

I=E2=80=99m wondering if a committer could = look at two minor pull requests Marco has made recently and approve = them? 

1) = Adding WOOgnl framework to JavaMonitor
https://github.com/wocommunity/wonder/pull/1012
This one is real simple, changing the project to include the = existing WOnder WOOgnl framework. It will lay the groundwork to make it = more enticing for Marco to continue to develop JavaMonitor. He won=E2=80=99= t be doing any wild logic within bindings but be doing basic things, it = would make it simpler for him to have WOOgnl = available. 

I've suggested Marco amend the PR to = include the corresponding Maven dependency in the POM.

2) = Correcting HTML within JavaMonitor
https://github.com/wocommunity/wonder/pull/1013
This one is simple too, restructuring Main to pass basic HTML = validation. For example, meta tags should not be outside of the HTML = tags. This pull requests puts the meta-refresh inside of the HEAD = tags. 

Merged.

If = these could be approved and committed in the next two weeks that would = be awesome :-) Let=E2=80=99s keep Marco excited and wanting to = contribute more :-) Later pull requests will likely be more = substantial/interesting. 

I look forward to = them!


-- 
Paul = Hoadley
https://logicsquad.net/
https://www.linkedin.com/company/logic-squad/

<= /div>
= --Apple-Mail=_28F801A2-E1EA-41D0-AA94-DC29D01D2AFE--